doc: rewrite doc for signed int::{carrying_add,borrowing_sub} #103236

tspiteri · 2022-10-19T09:59:07Z

Reword the documentation for bigint helper methods, signed int::{carrying_add,borrowing_sub} (#85532).

This change is a follow-up to #101889, which was for the unsigned methods.

rustbot · 2022-10-19T09:59:10Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-10-19T09:59:11Z

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

tspiteri · 2022-10-19T10:00:04Z

r? @m-ou-se

m-ou-se · 2023-01-02T14:32:38Z

@bors r+

bors · 2023-01-02T14:32:40Z

📌 Commit 4e38d06 has been approved by m-ou-se

It is now in the queue for this repository.

bors · 2023-01-02T16:41:13Z

⌛ Testing commit 4e38d06 with merge 0ae12cbdd3f3b3dd26171625510c7b428c898f7e...

bors · 2023-01-02T17:18:53Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-01-02T17:59:55Z

The job x86_64-apple-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Some tests failed in compiletest suite=debuginfo mode=debuginfo host=x86_64-apple-darwin target=x86_64-apple-darwin

failures:

---- [debuginfo-lldb] src/test/debuginfo/borrowed-basic.rs stdout ----
NOTE: compiletest thinks it is using LLDB version 1400
NOTE: compiletest thinks it is using LLDB without native rust support
error: Error while running LLDB
error: Error while running LLDB
status: signal: 2 (SIGINT)
command: PYTHONPATH="/Applications/Xcode_14.0.1.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" PYTHONUNBUFFERED="1" "/usr/bin/python3" "/Users/runner/work/rust/rust/src/etc/lldb_batchmode.py" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/debuginfo/borrowed-basic.lldb/a" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/debuginfo/borrowed-basic.lldb/borrowed-basic.debugger.script"
--- stdout -------------------------------
LLDB batch-mode script
----------------------
Debugger commands script is '/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/debuginfo/borrowed-basic.lldb/borrowed-basic.debugger.script'.
Target executable is '/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/debuginfo/borrowed-basic.lldb/a'.
Current working directory is '/Users/runner/work/rust/rust'
Creating a target for '/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/debuginfo/borrowed-basic.lldb/a'
settings set auto-confirm true
version
version
lldb-1400.0.30.3 Apple Swift version 5.7 (swiftlang-5.7.0.127.4 clang-1400.0.29.50) 
command script import /Users/runner/work/rust/rust/./src/etc/lldb_lookup.py
type synthetic add -l lldb_lookup.synthetic_lookup -x '.*' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(alloc::([a-z_]+::)+)String$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^&(mut )?str$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^&(mut )?\[.+\]$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(std::ffi::([a-z_]+::)+)OsString$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(alloc::([a-z_]+::)+)Vec<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(alloc::([a-z_]+::)+)VecDeque<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(alloc::([a-z_]+::)+)BTreeSet<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(alloc::([a-z_]+::)+)BTreeMap<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(std::collections::([a-z_]+::)+)HashMap<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(std::collections::([a-z_]+::)+)HashSet<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(alloc::([a-z_]+::)+)Rc<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(alloc::([a-z_]+::)+)Arc<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(core::([a-z_]+::)+)Cell<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(core::([a-z_]+::)+)Ref<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(core::([a-z_]+::)+)RefMut<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^(core::([a-z_]+::)+)RefCell<.+>$' --category Rust
type summary add -F lldb_lookup.summary_lookup  -e -x -h '^core::num::([a-z_]+::)*NonZero.+$' --category Rust
type category enable Rust

breakpoint set --file 'borrowed-basic.rs' --line 158
Breakpoint 1: where = a`borrowed_basic::main::hb88626abe4f7b94a + 298 at borrowed-basic.rs:158:5, address = 0x0000000100003cba 
DEBUG: breakpoint added, id = 1
run
Process 75364 stopped * thread #1, name = 'main', queue = 'com.apple.main-thread', stop reason = breakpoint 1.1 frame #0: 0x0000000100003cba a`borrowed_basic::main::hb88626abe4f7b94a at borrowed-basic.rs:158:5 155 let f64_val: f64 = 3.5; 156 let f64_ref: &f64 = &f64_val; 157 -> 158 zzz(); // #break ^ 159 } 160 161 fn zzz() {()} Target 0: (a) stopped. Process 75364 launched: '/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/debuginfo/borrowed-basic.lldb/a' (x86_64) 
DEBUG: registering breakpoint callback, id = 1
Error while trying to register breakpoint callback, id = 1, message = error: could not get num args: can't find callable: breakpoint_callback
print *bool_ref
print *bool_ref
(bool) $0 = true 
print *int_ref
(long) $1 = -1 
print *i8_ref
(char) $2 = 'D' 
print *i16_ref
(short) $3 = -16 
print *i32_ref
(int) $4 = -32 
print *i64_ref
(long) $5 = -64 
print *uint_ref
(unsigned long) $6 = 1 
print *u8_ref
(unsigned char) $7 = 'd' 
print *u16_ref
(unsigned short) $8 = 16 
print *u32_ref
(unsigned int) $9 = 32 
print *u64_ref
(unsigned long) $10 = 64 
print *f32_ref
(float) $11 = 2.5 
print *f64_ref
(double) $12 = 3.5 


TIMEOUT: lldb_batchmode.py has been running for too long. Aborting!
--- stderr -------------------------------
--- stderr -------------------------------
warning: could not execute support code to read Objective-C class data in the process. This may reduce the quality of type information available.
Traceback (most recent call last):
Traceback (most recent call last):
  File "/Users/runner/work/rust/rust/src/etc/lldb_batchmode.py", line 224, in <module>
    debugger.Terminate()
  File "/Applications/Xcode_14.0.1.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python/lldb/__init__.py", line 4201, in Terminate
    return _lldb.SBDebugger_Terminate()
KeyboardInterrupt
------------------------------------------

tspiteri · 2023-01-03T19:43:51Z

I think the test failure is spurious.

ehuss · 2023-01-11T17:18:47Z

@bors retry

apple timeout on lldb_batchmode.py

doc: rewrite doc for signed int::{carrying_add,borrowing_sub} Reword the documentation for bigint helper methods, signed `int::{carrying_add,borrowing_sub}` (rust-lang#85532). This change is a follow-up to rust-lang#101889, which was for the unsigned methods.

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#103236 (doc: rewrite doc for signed int::{carrying_add,borrowing_sub}) - rust-lang#103800 (Stabilize `::{core,std}::pin::pin!`) - rust-lang#106097 (Migrate mir_build diagnostics 2 of 3) - rust-lang#106170 (Move autoderef to `rustc_hir_analysis`) - rust-lang#106323 (Stabilize f16c_target_feature) - rust-lang#106360 (Tweak E0277 `&`-removal suggestions) - rust-lang#106524 (Label `struct/enum constructor` instead of `fn item`, mention that it should be called on type mismatch) - rust-lang#106739 (Remove `<dyn AstConv<'tcx>>::fun(c, ...)` calls in favour of `c.astconv().fun(...)`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 19, 2022

rust-highfive assigned thomcc Oct 19, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2022

rust-highfive assigned m-ou-se and unassigned thomcc Oct 19, 2022

doc: rewrite doc for signed int::{carrying_add,borrowing_sub}

4e38d06

tspiteri force-pushed the redoc-int-adc-sbb branch from fa1314a to 4e38d06 Compare October 19, 2022 11:26

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 2, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2023

matthiaskrgr mentioned this pull request Jan 12, 2023

Rollup of 7 pull requests #106756

Closed

compiler-errors mentioned this pull request Jan 12, 2023

Rollup of 8 pull requests #106760

Merged

bors merged commit e23b0fd into rust-lang:master Jan 12, 2023

rustbot added this to the 1.68.0 milestone Jan 12, 2023

tspiteri deleted the redoc-int-adc-sbb branch January 14, 2023 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

doc: rewrite doc for signed int::{carrying_add,borrowing_sub} #103236

doc: rewrite doc for signed int::{carrying_add,borrowing_sub} #103236

Uh oh!

tspiteri commented Oct 19, 2022

Uh oh!

rustbot commented Oct 19, 2022

Uh oh!

rust-highfive commented Oct 19, 2022

Uh oh!

tspiteri commented Oct 19, 2022

Uh oh!

m-ou-se commented Jan 2, 2023

Uh oh!

bors commented Jan 2, 2023

Uh oh!

bors commented Jan 2, 2023

Uh oh!

bors commented Jan 2, 2023

Uh oh!

rust-log-analyzer commented Jan 2, 2023

Uh oh!

tspiteri commented Jan 3, 2023

Uh oh!

ehuss commented Jan 11, 2023

Uh oh!

Uh oh!

doc: rewrite doc for signed int::{carrying_add,borrowing_sub} #103236

doc: rewrite doc for signed int::{carrying_add,borrowing_sub} #103236

Uh oh!

Conversation

tspiteri commented Oct 19, 2022

Uh oh!

rustbot commented Oct 19, 2022

Uh oh!

rust-highfive commented Oct 19, 2022

Uh oh!

tspiteri commented Oct 19, 2022

Uh oh!

m-ou-se commented Jan 2, 2023

Uh oh!

bors commented Jan 2, 2023

Uh oh!

bors commented Jan 2, 2023

Uh oh!

bors commented Jan 2, 2023

Uh oh!

rust-log-analyzer commented Jan 2, 2023

Uh oh!

tspiteri commented Jan 3, 2023

Uh oh!

ehuss commented Jan 11, 2023

Uh oh!

Uh oh!